Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prepare next-major-spec for release #421

Merged
merged 14 commits into from
Nov 30, 2023
Merged

fix: prepare next-major-spec for release #421

merged 14 commits into from
Nov 30, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Aug 7, 2023 •
edited
Loading

Description
This PR adds the final changes to next-major-spec that is needed before release, this includes:

  • Added migration guide for v6
  • Added migration guide for v5 (was missing)
  • Added v3 schemas to the all-schema store

Related issue(s)
Blocking #208

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni jonaslagoni mentioned this pull request Aug 7, 2023
Merged
@jonaslagoni jonaslagoni changed the title feat: prepare next-major-spec for release fix: prepare next-major-spec for release Oct 9, 2023
@jonaslagoni
Copy link
Member Author

Adapted this PR to match the desire to not release before the spec.

@jonaslagoni jonaslagoni requested a review from derberg October 9, 2023 15:25
smoya
smoya requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derberg @jonaslagoni Would you mind answering (maybe it has been answered already somewhere else) the following https://github.com/asyncapi/spec-json-schemas/pull/421/files/b43d3d650d24ab99c9e2a7436d1ba7d1adb60bc9..340e842a3a27498361022e743b4239fbb77d593e#r1350501180 before moving forward?

Thank you 🙏

fmvilas
fmvilas approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

char0n
char0n approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derberg
Copy link
Member

derberg commented Nov 28, 2023

looks like everybody agree that #421 (comment) is a direction so @jonaslagoni you can update this PR and we can merge it before release

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

smoya
smoya approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@fmvilas
Copy link
Member

fmvilas commented Nov 30, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 24e105a into asyncapi:next-major-spec Nov 30, 2023
11 checks passed
@derberg
Copy link
Member

derberg commented Nov 30, 2023

oh wait, so what about below @jonaslagoni

looks like everybody agree that #421 (comment) is a direction so @jonaslagoni you can update this PR and we can merge it before release

@fmvilas
Copy link
Member

fmvilas commented Nov 30, 2023

Looks like I was too fast pressing the button. @jonaslagoni feel free to create another PR to address your concerns, if any.

This was referenced Nov 30, 2023
Merged
Open
@jonaslagoni jonaslagoni deleted the add_migration_guide_v6 branch November 30, 2023 18:20
@jonaslagoni
Copy link
Member Author

All good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalelane dalelane dalelane left review comments

@smoya smoya smoya approved these changes

@fmvilas fmvilas fmvilas approved these changes

@char0n char0n char0n approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jonaslagoni @derberg @fmvilas @char0n @smoya @dalelane @asyncapi-bot